Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(php): undiscriminated unions #4783

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(php): undiscriminated unions #4783

wants to merge 4 commits into from
+29,214 −2,940

Conversation

dcb6
Copy link
Contributor

@dcb6 dcb6 commented Sep 30, 2024 •
edited
Loading

This PR introduces support in PHP for undiscriminated unions, including the following:

  • serde for undiscriminated type properties, with types indicated by a Union annotation (the previous Union class was easily converted into an annotation)
  • serde for responses that are direct unions

TODO:

  • serde for requests that are direct unions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi Awaiting requested review from dsinghvi dsinghvi will be requested when the pull request is marked ready for review dsinghvi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcb6