infra: docker build #305
Merged
infra: docker build #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benni347
force-pushed
the
docker-build
branch
from
b9e2e0a
to
15aebfb
Compare
|
Thank you @benni347! The Dockerfile seems good. I just find out about github container registry. I would like to test this feature before merging this PR. The merge could be delayed. |
|
Thank you @benni347 Everything is fine, I just added a couple of things to the README file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sadly can't yet compile it for other architectures because of: dnfield/vector_graphics#249.
Maybe I could generate the vector images before the docker build and then copy them into the correct directory, let me know if I should look at this approach or if linux/amd64 is fine.
Closes: #241