bootstrap: x doc --open ferrocene/doc no longer opens a dozen web pages#1883
Draft
bootstrap: x doc --open ferrocene/doc no longer opens a dozen web pages#1883
Conversation
… flag The original motivation for adding this `path.starts_with` check was to allow things like `--skip=src/etc`. But it affects quite a lot more things than just `--skip`; bootstrap is really not designed for the case when multiple Steps match the same filter. For example, `x test src` does ... something! Not sure what, but something! Change `starts_with` to only affect `--skip`, not anything else. The original motivation for this was to make it so that `x doc src/doc --open` doesn't open a dozen different books, but I expect it to fix various other steps in bootstrap as well.
In general, the rationale for `--open` is to only open HTML files if they were "explicitly" invoked from the CLI (e.g. `x doc --open library/core`). The existing logic did not do that. Instead it opened the docs unconditionally when a subset of the crates was requested. This is unfortunate for other Steps in bootstrap, which may wish to `ensure()` the standard library docs without opening them. Change `Std` to check if it was explicitly invoked, rather than assuming it's the case.
…ages The previous commits in this chain make it so that the pages no longer open. This commit just opens the main index page, now that it's no longer being implicitly opened.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft until i upstream the first two commits