fix: conditional requirements install and cross-platform venv activation - #177
Open
saurabhhhcodes wants to merge 1 commit into
Open
fix: conditional requirements install and cross-platform venv activation#177saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
Closes fetchai#143 Dockerfile: COPY /requirements.txt failed at build time for examples without a requirements.txt (web3, mcp-agents, gemini-quickstart). Copy the example first, then pip install only when requirements.txt exists. setup.sh: hardcoded .venv/bin/activate breaks on Windows Git Bash/MSYS2, where venv creates .venv/Scripts/activate. Source the correct script by checking both paths, and fail with a clear message if neither exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
Problem
Dockerfileunconditionally ranCOPY ${EXAMPLE}/requirements.txt— build crashes for examples without a requirements.txt (web3,mcp-agents,gemini-quickstart).setup.shhardcodedsource .venv/bin/activate— fails on Windows Git Bash/MSYS2, where venv creates.venv/Scripts/activate.Changes
Dockerfile
${EXAMPLE}/first, then install requirements only when the file exists:setup.sh
Verification
bash -n setup.sh— syntax OK