feat: better exception handling #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrriehl
changed the title
jrriehl
changed the title
Archento
previously approved these changes
Aug 25, 2023
There was a problem hiding this comment.
The added try-catch blocks all look good to me.
I'm just wondering if catching those specific errors at the agent level and forwarding them to the logger is enough or if we should also try-catch at a deeper level like context.py:L245-254.
Just an idea, otherwise I think it's a good start :)
Good point, I added some exception handling here as well. |
Archento
previously approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally tried to ensure we catch exceptions wherever a task is awaited or created.