Integrating BLIP Image Captioning model with UAgents #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrriehl
reviewed
Sep 13, 2023
jrriehl
reviewed
Sep 13, 2023
jrriehl
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Nice one!
I was able to get this to run, but the first time I got an error:
INFO: [blip_user]: Got error from uagent: error='Error: Model Salesforce/blip-image-captioning-large is currently loading'
It might be useful to add some retry logic, especially if this a common error. For example, you could reduce the interval period and add a storage flag to indicate when the caption is successfully generated so that it does not need to continue to make requests.
|
Hi @jrriehl , I have taken your suggestions/feedback and resolved the issues accordingly. Please have a look. |
|
Thank you for pointing towards storage feature, I've learned something new. |
jrriehl
reviewed
Sep 15, 2023
integrations/blip-image-captioning-large/src/agents/blip_agent.py
Outdated
Show resolved
Hide resolved
jrriehl
reviewed
Sep 15, 2023
integrations/blip-image-captioning-large/src/agents/blip_agent.py
Outdated
Show resolved
Hide resolved
jrriehl
reviewed
Sep 15, 2023
integrations/blip-image-captioning-large/src/agents/blip_user.py
Outdated
Show resolved
Hide resolved
jrriehl
reviewed
Sep 15, 2023
integrations/blip-image-captioning-large/src/agents/blip_user.py
Outdated
Show resolved
Hide resolved
…ake protocol details available agentverse
|
@jrriehl made changes as per your comments, please review! |
jrriehl
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example demonstrates the integration of BLIP image captioning into the UAgent Ecosystem. It also provides insight on how large byte data, like images, are passed using encoding to the agent.