Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename broadcast method #250

Merged
merged 2 commits into from
Mar 6, 2024
Merged

chore: rename broadcast method #250

merged 2 commits into from
Mar 6, 2024

Conversation

Archento
Copy link
Member

@Archento Archento commented Mar 5, 2024

experimental -> official

@Archento Archento requested a review from jrriehl March 5, 2024 08:41
jrriehl
jrriehl reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maintain experimental_broadcast as a simple wrapper for broadcast so as not to break code that is currently using this? Maybe with a deprecation warning?

@Archento
Copy link
Member Author

Archento commented Mar 6, 2024

Screenshot 2024-03-06 at 10 46 48

works like a charm

jrriehl
jrriehl approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Archento Archento merged commit 4236ce7 into main Mar 6, 2024
9 checks passed
@Archento Archento deleted the fix/rename-broadcast branch March 6, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archento @jrriehl