Skip to content

Commit

Permalink
fix(transport): Correctly handle messages from non-standard BACnet po…
Browse files Browse the repository at this point in the history
…rt numbers
  • Loading branch information
adam-nielsen committed Jan 31, 2019
1 parent 0458708 commit a28bcad
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions lib/transport.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
const createSocket = require('dgram').createSocket;
const EventEmitter = require('events').EventEmitter;

const DefaultBACnetPort = 47808;

class Transport extends EventEmitter {
constructor(settings) {
super();
this._settings = settings;
this._server = createSocket({type: 'udp4', reuseAddr: true});
this._server.on('message', (msg, rinfo) => this.emit('message', msg, rinfo.address));
this._server.on('message', (msg, rinfo) => this.emit('message', msg, rinfo.address + (rinfo.port === DefaultBACnetPort ? '' : ':' + rinfo.port)));
this._server.on('error', (err) => this.emit('message', err));
}

Expand All @@ -21,7 +23,8 @@ class Transport extends EventEmitter {
}

send(buffer, offset, receiver) {
this._server.send(buffer, 0, offset, this._settings.port, receiver);
const [address, port] = receiver.split(':');
this._server.send(buffer, 0, offset, port || DefaultBACnetPort, address);
}

open() {
Expand Down

0 comments on commit a28bcad

Please sign in to comment.