Remove setState call from ErrorBoundary render fn

fhlavac · Aug 30, 2023 · 02f4d7a · 02f4d7a
1 parent 6f4073b
commit 02f4d7a
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/packages/module/src/ErrorBoundary/ErrorBoundary.tsx b/packages/module/src/ErrorBoundary/ErrorBoundary.tsx
@@ -41,15 +41,24 @@ class ErrorBoundary extends React.Component<React.PropsWithChildren<ErrorPagePro
     return { hasError: true, error, historyState: history.state };
   }
 
-  render() {
-
+  updateState = () => {
     if (this.state.historyState !== history.state) {
       this.setState({
         hasError: false,
         historyState: history.state,
       });
     }
+  };
+
+  componentDidUpdate(): void {
+    this.updateState();
+  }
 
+  componentDidMount(): void {
+    this.updateState();
+  }
+
+  render() {
     if (this.state.hasError) {
       if (this.props.silent) {
         return null;