Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fnc3 and win versioning #11

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gpongelli
Copy link
Contributor

  • some codes that start with FNC3 returns "Invalid character in string"
  • add version number to Windows build

@fhunleth
Copy link
Owner

Hi @gpongelli! Do you have an example of a string that fails?

@gpongelli
Copy link
Contributor Author

sure!
take a look at this barcode
image
you can find it into the QuickScan QD2200 Product Reference Guide, page 25.
the label, expressed using this library's input, is [FNC3]RevA\r:

  • using the actual master's commit, the above string will exit with "invalid character in string" due this if block, even if estimate_length's return value is not zero
  • using this fix, the above string will correctly generate the label

@gpongelli
Copy link
Contributor Author

FYI this changes works only on windows.

on raspberry hw, I still get "Invalid characters in string".

@gpongelli
Copy link
Contributor Author

last commit fixes ARM execution (linux) and works also for x86 (windows).

@gpongelli gpongelli marked this pull request as draft March 30, 2023 12:35
@gpongelli gpongelli marked this pull request as ready for review March 30, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants