Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mari #68

Merged
merged 20 commits into from
Mar 31, 2023
Merged

Implement mari #68

merged 20 commits into from
Mar 31, 2023

Conversation

keiranjprice101
Copy link
Collaborator

@keiranjprice101 keiranjprice101 commented Mar 29, 2023

closes #61

Description

This PR implements the majority of the mari functionality, with one part left untested.
The part that is untested will be covered in #71 post meeting with Duc

What is complete and tested in this PR:

  • Introduction of new extraction pattern - outlined and documented in README - This prevents unecessarily double ingesting nexus files.
  • Adding MARI specific inputs - These are added from the nexus files, if none exist on the nexus file, it will populate the default values
  • Small Qualit of life change - Test paramerisation for ingestion

As a new issue is opened from this, there is an overall coverage drop of 2%, but this will be remedied post #71

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 88.05% and project coverage change: -2.08 ⚠️

Comparison is base (20592b7) 97.06% compared to head (808d619) 94.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   97.06%   94.99%   -2.08%     
==========================================
  Files          18       19       +1     
  Lines         579      719     +140     
==========================================
+ Hits          562      683     +121     
- Misses         17       36      +19     
Impacted Files Coverage Δ
rundetection/rules/mari_rules.py 37.03% <37.03%> (ø)
rundetection/run_detection.py 94.54% <50.00%> (-1.69%) ⬇️
rundetection/rules/factory.py 80.00% <80.00%> (ø)
rundetection/ingest.py 100.00% <100.00%> (ø)
test/test_ingest.py 99.05% <100.00%> (+1.32%) ⬆️
test/test_specifications.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@keiranjprice101 keiranjprice101 requested a review from Pasarus March 31, 2023 07:25
@keiranjprice101 keiranjprice101 changed the title draft: Implement mari Implement mari Mar 31, 2023
@keiranjprice101 keiranjprice101 marked this pull request as ready for review March 31, 2023 07:25
@Pasarus Pasarus merged commit b2d8659 into main Mar 31, 2023
@Pasarus Pasarus deleted the implement_mari branch March 31, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that Run detection has the MARI specification added
2 participants