Skip to content

Enforce a max range for CI chunk sizes #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssteele110 merged 4 commits into from
Dec 10, 2025
Merged

Enforce a max range for CI chunk sizes #84

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f133a0c
Enforce a range for supported chunk sizes in CI
ssteele110 Dec 9, 2025
c7bca9f
Add env variable into suite bin packing
ssteele110 Dec 9, 2025
08c13d5
Pass environment variables through
ssteele110 Dec 9, 2025
73c65a7
Add additional unit tests
ssteele110 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions ruby/lib/ci/queue/strategy/suite_bin_packing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ def initialize(config, redis: nil)
else
{}
end

@max_duration = config&.suite_max_duration || 120_000
# Enforce the max chunk duration falls within this range.
@minimum_max_duration = config&.suite_max_duration || 120_000
@maximum_max_duration = config&.suite_max_duration || 300_000
@fallback_duration = config&.timing_fallback_duration || 100.0
@buffer_percent = config&.suite_buffer_percent || 10

Expand Down Expand Up @@ -106,8 +107,8 @@ def calculate_dynamic_max_duration(tests)

puts "parallel_job_count: #{parallel_job_count}"

# If no parallel job count, fall back to configured max_duration
return @max_duration unless parallel_job_count && parallel_job_count > 0
# If no parallel job count, fall back to configured minimum max_duration
return @minimum_max_duration unless parallel_job_count && parallel_job_count > 0

# Calculate total duration of all tests
total_duration = tests.sum do |test|
Expand All @@ -118,11 +119,12 @@ def calculate_dynamic_max_duration(tests)
# This gives us the target max chunk time
base_max_duration = total_duration.to_f / parallel_job_count

puts "base_max_duration: #{base_max_duration}, @max_duration: #{@max_duration}"
puts "base_max_duration: #{base_max_duration}, @minimum_max_duration: #{@minimum_max_duration}, @maximum_max_duration: #{@maximum_max_duration}"

# Ensure we don't go below a minimum reasonable value
# Ensure we don't go above or below reasonable floor values.
# Use configured max_duration as a floor to prevent extremely small chunks
[base_max_duration, @max_duration].max
max_duration = [base_max_duration, @maximum_max_duration].min
[max_duration, @minimum_max_duration].max
end

def create_chunks_for_suite(suite_name, suite_tests, max_duration)
Expand Down