Emoji Selector: Make A11y Accessible with Live Search Results #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyefigma
force-pushed
the
jye/aria-live-search
branch
from
f074194 to
efc7032
Compare
jyefigma
changed the title
jyefigma
force-pushed
the
jye/aria-live-search
branch
3 times, most recently
from
2cd9c1b to
e7f5219
Compare
jyefigma
force-pushed
the
jye/aria-live-search
branch
from
4c99e1f to
82ef016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that search results also prompt an update in the screenreader
We do this by debouncing the search (so that only typing and pausing for 0.5seconds brings up new results) to not spam the screenreader, and adding a screenreader only text that is wrapped in aria-live to be announced when search is completed
https://app.asana.com/1/10497086658021/project/1209610084066286/task/1210150747556906?focus=true