Fix Emoji Picker Padding #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kliu-figma
approved these changes
Aug 1, 2025
kliu-figma
left a comment
kliu-figma
left a comment
There was a problem hiding this comment.
That's kind of disturbing haha. This is awesome as a quick patch, thanks for doing that so fast, but I guess we should probably fix the root cause at some point!
|
(I would have expected the shadow DOM to properly isolate conflicting var names) EDIT: nvm, apparently it doesn't affect CSS vars |
Author
Yup, i'm assuming frontend platform might be able to help here, just waiting on FCP to deploy and make sure we're all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorders CSS classes to fix padding
The issue appears to have been caused by a conflict with an existing
var(--padding)because when I rename, the UI is fixedI also reordered
padding-lrandscrollfor posterity, as the latter previously overrode the former