Skip to content

Conversation

@julia-wright-figma
Copy link
Collaborator

  • update the hardcoded URL in images.js to match the path currently used by fullscreen for noto color emojis in figjam
    • this code path is not currently used (according to the comment in that file and my own code searching), but we will be using it for maker week 2025 emoji stamps project.
  • change PickerElement to preserve props.set as this switches between different emoji sets, which we now want to be able to do on a per-element basis.

usage after this change:

  • existing usages with set="native" are unchanged
  • new usages can pass set="google" to get emojis from Noto Color Emoji font

Copy link

@jyefigma jyefigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me (not 100% what this is doing, but doesn't seem crazy)
just before i approve, do you have a) some feature flagging going on so that this doesn't just roll out upon next deploy in the mono-repo? and b) do you have a commit preview in the mono rep that i can test out?

@julia-wright-figma
Copy link
Collaborator Author

@jyefigma

seems fine to me (not 100% what this is doing, but doesn't seem crazy) just before i approve, do you have
a) some feature flagging going on so that this doesn't just roll out upon next deploy in the mono-repo?

the monorepo code that uses this new code path is behind a feature flag, but the corresponding update to package.json in the monorepo is not. (is there a way to put a dependency update behind a feature flag?)

and b) do you have a commit preview in the mono rep that i can test out?

yes, see monorepo PR here https://github.com/figma/figma/pull/553687

@julia-wright-figma julia-wright-figma merged commit 5493574 into figma-release-3 Aug 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants