-
-
Notifications
You must be signed in to change notification settings - Fork 4k
[5.x] Feature: Allow enum in HasAuthorization trait #18856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danharrin
merged 5 commits into
filamentphp:5.x
from
webard:feature/allow-enum-in-authorize-trait
Jan 9, 2026
+190
−5
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2edcd10
UnitEnum in HasAuthorization trait
webard 005aa08
Add Rector script
danharrin dff4c9f
Update SimpleMethodChangesRector.php
danharrin ad1c227
Merge branch '5.x' into pr/18856
danharrin f159e5c
Update SimpleMethodChangesRector.php
danharrin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
packages/upgrade/src/Rector/SimpleMethodChangesRector.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| <?php | ||
|
|
||
| namespace Filament\Upgrade\Rector; | ||
|
|
||
| use Closure; | ||
| use Filament\Resources\Resource; | ||
| use PhpParser\Node; | ||
| use PhpParser\Node\Identifier; | ||
| use PhpParser\Node\Name\FullyQualified; | ||
| use PhpParser\Node\Param; | ||
| use PhpParser\Node\Stmt\Class_; | ||
| use PhpParser\Node\Stmt\ClassMethod; | ||
| use PhpParser\Node\Stmt\Enum_; | ||
| use PhpParser\Node\UnionType; | ||
| use PHPStan\Type\ObjectType; | ||
| use Rector\Rector\AbstractRector; | ||
|
|
||
| class SimpleMethodChangesRector extends AbstractRector | ||
| { | ||
| /** | ||
| * @return array<array{ | ||
| * class: class-string | array<class-string>, | ||
| * changes: array<string, Closure>, | ||
| * }> | ||
| */ | ||
| public function getChanges(): array | ||
| { | ||
| $addUnitEnumToAuthorizationActionParamModifier = static function (ClassMethod $node): void { | ||
| foreach ($node->getParams() as $param) { | ||
| if ($param->var->name !== 'action') { | ||
| continue; | ||
| } | ||
|
|
||
| $param->type = new UnionType([new Identifier('string'), new FullyQualified('UnitEnum')]); | ||
| } | ||
| }; | ||
|
|
||
| return [ | ||
| [ | ||
| 'class' => [ | ||
| Resource::class, | ||
| ], | ||
| 'changes' => [ | ||
| 'getAuthorizationResponse' => $addUnitEnumToAuthorizationActionParamModifier, | ||
| 'can' => $addUnitEnumToAuthorizationActionParamModifier, | ||
| 'authorize' => $addUnitEnumToAuthorizationActionParamModifier, | ||
| ], | ||
| ], | ||
| ]; | ||
| } | ||
|
|
||
| public function getNodeTypes(): array | ||
| { | ||
| return [Class_::class, Enum_::class]; | ||
| } | ||
|
|
||
| /** | ||
| * @param Class_ | Enum_ $node | ||
| */ | ||
| public function refactor(Node $node): ?Node | ||
| { | ||
| $touched = false; | ||
|
|
||
| foreach ($this->getChanges() as $change) { | ||
| if (! $this->isClassMatchingChange($node, $change)) { | ||
| continue; | ||
| } | ||
|
|
||
| foreach ($change['changes'] as $methodName => $modifier) { | ||
| foreach ($node->getMethods() as $method) { | ||
| if (! $this->isName($method, $methodName)) { | ||
| continue; | ||
| } | ||
|
|
||
| $modifier($method); | ||
|
|
||
| $touched = true; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return $touched ? $node : null; | ||
| } | ||
|
|
||
| /** | ||
| * @param array{ | ||
| * class: class-string | array<class-string>, | ||
| * } $change | ||
| */ | ||
| public function isClassMatchingChange(Class_ | Enum_ $class, array $change): bool | ||
| { | ||
| $classes = is_array($change['class']) ? | ||
| $change['class'] : | ||
| [$change['class']]; | ||
|
|
||
| $classes = array_map(fn (string $class): string => ltrim($class, '\\'), $classes); | ||
|
|
||
| foreach ($classes as $classToCheck) { | ||
| if ($class instanceof Enum_) { | ||
| foreach ($class->implements as $enumInterface) { | ||
| if ($enumInterface->toString() === $classToCheck) { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| continue; | ||
| } | ||
|
|
||
| if ($this->isObjectType($class, new ObjectType($classToCheck))) { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?php | ||
|
|
||
| use Filament\Upgrade\Rector; | ||
| use Rector\Config\RectorConfig; | ||
|
|
||
| return static function (RectorConfig $rectorConfig): void { | ||
| $rectorConfig->rules([ | ||
| Rector\SimpleMethodChangesRector::class, | ||
| ]); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.