Skip to content

Conversation

@Devonab
Copy link
Contributor

@Devonab Devonab commented Jan 5, 2026

This pull request aims to address the same issue reported in v4.x here: #17646
for reference : Devonab/filament-easy-footer#16 (comment)

Description

When one sets up their panel using the one of following methods:

->sidebarCollapsibleOnDesktop()
->sidebarFullyCollapsibleOnDesktop()

The content is no longer at a minimum height of 100%, which can be a bit troublesome when one wishes to place an element in the renderHook PanelsRenderHook::FOOTER.

I replaced the h-full present in packages/filament/packages/panels/resources/views/components/layout/index.blade.php.

Visual changes

Before :
image

After :
image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Jan 5, 2026
@danharrin danharrin added the bug Something isn't working label Jan 6, 2026
@danharrin danharrin added this to the v3 milestone Jan 6, 2026
@danharrin
Copy link
Member

I don't think we can merge this change unfortunately, it might break users' existing pages if the topbar height has been customised or something. This was less of a risk to merge early in a major version change like v4.

In your plugin, I would suggest injecting the CSS that does this to fix your user's problem.

@danharrin danharrin closed this Jan 9, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Jan 9, 2026
@Devonab
Copy link
Contributor Author

Devonab commented Jan 9, 2026

Thank you for the follow-up, and all good, I understand. I will do what you suggest. it's a good idea as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants