fix: ensure main container fills viewport with collapsible si… #18873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't think we can merge this change unfortunately, it might break users' existing pages if the topbar height has been customised or something. This was less of a risk to merge early in a major version change like v4. In your plugin, I would suggest injecting the CSS that does this to fix your user's problem. |
Contributor
Author
|
Thank you for the follow-up, and all good, I understand. I will do what you suggest. it's a good idea as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to address the same issue reported in v4.x here: #17646
for reference : Devonab/filament-easy-footer#16 (comment)
Description
When one sets up their panel using the one of following methods:
The content is no longer at a minimum height of 100%, which can be a bit troublesome when one wishes to place an element in the renderHook PanelsRenderHook::FOOTER.
I replaced the
h-fullpresent inpackages/filament/packages/panels/resources/views/components/layout/index.blade.php.Visual changes
Before :
After :
Functional changes
composer cscommand.