Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cid/multihash #239

Merged
merged 4 commits into from
Nov 21, 2024
Merged

chore: update cid/multihash #239

merged 4 commits into from
Nov 21, 2024

Conversation

Stebalien
Copy link
Member

Pull in a large breaking change to cid & multihash, updating the FVM to handle these changes as well.

Pull in a large breaking change to cid & multihash, updating the FVM to
handle these changes as well.
@Stebalien
Copy link
Member Author

Hm. That test failure is interesting.

The CborStore is now more strict about what IPLD codecs it allows.
@Stebalien
Copy link
Member Author

Ah, it was a bug fix.

@coveralls
Copy link

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 11944931930

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 89.041%

Changes Missing Coverage Covered Lines Changed/Added Lines %
frc46_token/src/token/state.rs 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
fvm_actor_utils/src/receiver/mod.rs 3 62.5%
frc46_token/src/token/state.rs 4 90.22%
Totals Coverage Status
Change from base Build 11293963160: -0.2%
Covered Lines: 3770
Relevant Lines: 4234

💛 - Coveralls

@Stebalien Stebalien requested a review from rvagg November 21, 2024 00:52
@Stebalien Stebalien merged commit 82f3972 into main Nov 21, 2024
4 checks passed
@Stebalien Stebalien deleted the steb/update-multihash branch November 21, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants