Dockerized build environment for reproducible WASM builds #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I wonder if |
|
@Stebalien is the existing PR sufficient? I'm sure your above suggestions are worth pursuing but this looks like its way better than the current state. @lemmih other than getting past review and into builtin actors CI is anything else blocking you? |
|
Yeah, this is definitely better than what we have. |
|
So what are the changes that still need to be made to get merge this? And what additional work needs to be done after merging this to fully address #171? |
|
Superceded by #865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue #171. This allows for reproducible builds on x86-64. It may or may not be sufficient for auditing.