feat: Snap Deals #52
Merged
feat: Snap Deals #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/snap
branch
3 times, most recently
from
41bcbeb
to
647cc99
Compare
magik6k
force-pushed
the
feat/snap
branch
3 times, most recently
from
15f935b
to
1a025aa
Compare
LexLuthr
requested changes
Jun 24, 2024
LexLuthr
reviewed
Jun 24, 2024
magik6k
commented
Jun 25, 2024
snadrus
requested changes
Jun 25, 2024
|
Can you describe, maybe in a godoc:
|
magik6k
force-pushed
the
feat/snap
branch
4 times, most recently
from
89e8ab9
to
984e092
Compare
This was missing, now is decided by the config
Those two are the same as normal deal ingest |
magik6k
force-pushed
the
feat/snap
branch
2 times, most recently
from
f3161d6
to
10ecd79
Compare
LexLuthr
approved these changes
Jul 16, 2024
snadrus
reviewed
Jul 16, 2024
|
Tested on my setup, appears to work well. |
snadrus
reviewed
Jul 18, 2024
|
|
||
| shouldSeal := func(sector *openSector) bool { | ||
| // Start sealing a sector if | ||
| // 1. If sector is full |
There was a problem hiding this comment.
in what documentation is this reflected?
There was a problem hiding this comment.
iiuc docs for snap will be written soon
| continue | ||
| } | ||
|
|
||
| // //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// TODO ADD SNAP SECTOR EXP CHECKS |
There was a problem hiding this comment.
tracking bug for this TODO?
| @@ -66,6 +66,8 @@ func (l *LMRPCProvider) WorkerJobs(ctx context.Context) (map[uuid.UUID][]storifa | |||
| } | |||
|
|
|||
| func (l *LMRPCProvider) SectorsStatus(ctx context.Context, sid abi.SectorNumber, showOnChainInfo bool) (lapi.SectorInfo, error) { | |||
| // TODO: Add snap, Add open_sector_pieces | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.