Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add exhaustive list of binary mimes #130

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

orvn
Copy link
Collaborator

@orvn orvn commented Jan 24, 2024

Includes a more exhaustive list of binary mime types in .gitattributes. This prevents an issue where newlines were appended to non-newline-eol files, which is a good check, but should be excluded for binaries.

@orvn orvn requested a review from tikagan January 24, 2024 20:10
@orvn orvn self-assigned this Jan 24, 2024
Copy link
Collaborator

@tikagan tikagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tikagan tikagan merged commit 2312413 into main Jan 24, 2024
@tikagan tikagan deleted the fix-gitattributes-mimes branch January 24, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants