Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobile text truncation #131

Merged
merged 5 commits into from
Jan 25, 2024
Merged

fix: mobile text truncation #131

merged 5 commits into from
Jan 25, 2024

Conversation

svvimming
Copy link
Collaborator

@svvimming svvimming commented Jan 25, 2024 •
edited
Loading

  • Add !important to display: none on nav element that shouldn't appear on mobile.
  • prevent site header translateY occurring while the mobile nav is open
  • Correct project card description truncation on mobile

@svvimming svvimming self-assigned this Jan 25, 2024
@svvimming svvimming marked this pull request as draft January 25, 2024 17:05
@svvimming svvimming requested a review from orvn January 25, 2024 21:46
@svvimming svvimming marked this pull request as ready for review January 25, 2024 21:46
orvn
orvn approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Tested in a few mobile browsers.

@orvn orvn merged commit 85a73d5 into main Jan 25, 2024
4 checks passed
@orvn orvn deleted the fix-mobile-text-truncation branch January 25, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orvn orvn orvn approved these changes

Assignees

@svvimming svvimming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svvimming @orvn