Update cbor-gen #87
Closed
Update cbor-gen #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/cborgen_upd
branch
2 times, most recently
from
8207d7a to
736671c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 62.85% 63.36% +0.51%
==========================================
Files 8 8
Lines 1346 1365 +19
==========================================
+ Hits 846 865 +19
Misses 348 348
Partials 152 152
|
|
Marking as draft until issues raised in filecoin-project/go-state-types#242 are resolved |
rvagg
force-pushed
the
rvagg/cborgen_upd
branch
from
736671c to
8cab194
Compare
|
Updated for master now that whyrusleeping/cbor-gen#94 is merged; but this is also now low priority as we no longer have breakage and the diff is relatively meaningless |
rvagg
force-pushed
the
rvagg/cborgen_upd
branch
from
8cab194 to
df0255e
Compare
rvagg
force-pushed
the
rvagg/cborgen_upd
branch
from
df0255e to
dd81127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: whyrusleeping/cbor-gen#92
@Stebalien this is that problem you mentioned over in whyrusleeping/cbor-gen#92; but the problem still exists that you either have to regenerate across the libraries like this, or you have to have to consistently configure in gen.go everywhere you use it to avoid conflicts. 🤷