Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added experimental terminal integration #13631

Draft
wants to merge 72 commits into
base: main
Choose a base branch
from
Draft

Feature: Added experimental terminal integration #13631

wants to merge 72 commits into from

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 1, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add terminal Integration #6235

Validation
How did you test these changes?

  • Did you build the app and test your changes?

Screenshots (optional)
image

@files-community files-community locked and limited conversation to collaborators Nov 1, 2023
@yaira2 yaira2 marked this pull request as draft May 28, 2024 01:48
@gave92
Copy link
Member Author

gave92 commented Jun 18, 2024

Rounded corners 💪

image

@0x5bfa
Copy link
Member

0x5bfa commented Jun 19, 2024

Omg, over 9000 addition. Would it be better to add round corner into css file?

@yaira2
Copy link
Member

yaira2 commented Jun 19, 2024

Omg, over 9000 addition. Would it be better to add round corner into css file?

If possible, but we haven't found a way to do this.

@gave92
Copy link
Member Author

gave92 commented Jun 19, 2024

Lol yeah completely new projects just for having rounded corners xD I do hope MS will add this to standard webview.

@gave92
Copy link
Member Author

gave92 commented Jun 21, 2024 •
edited
Loading

I don't suppose you'd be ok at least temporarily with this? 😇 Only way I could find that does not require using WebView2Ex.
image

@yaira2
Copy link
Member

yaira2 commented Jun 21, 2024

I won't mention it for now 😂

@yaira2
Switch status bar with terminal
d6e432e 
Revert "Switch status bar with terminal"

This reverts commit 8d793ed.

Update MainPage.xaml

Revert "Switch status bar with terminal"

This reverts commit 248347a.

Update StatusBar.xaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

@gumbarros gumbarros gumbarros left review comments

@0x5bfa 0x5bfa 0x5bfa left review comments

@XTorLukas XTorLukas XTorLukas requested changes

Assignees

@yaira2 yaira2

Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add terminal Integration
6 participants
@gave92 @hez2010 @0x5bfa @yaira2 @gumbarros @XTorLukas