Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Clean up Widgets #13808

Closed
wants to merge 23 commits into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 11, 2023

Summary

As the title.

Task Checklist

  • Clean up Widgets
  • Clean up
  • Apply requested changes

Known Issues

N/A

PR Checklist

  • Closes: Closes Code Quality: Refactor Widget controls #13210
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Steps To Validate Changes

  1. Launch the app
  2. Go to ...

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@0x5bfa
Copy link
Member Author

0x5bfa commented Nov 12, 2023

Ready for review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's a folder card item?

Copy link
Member Author

@0x5bfa 0x5bfa Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used by QuickAccessWidget. Contains folder thumbnails, path and name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

@0x5bfa 0x5bfa closed this Nov 18, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Cleanup-Widgets branch November 18, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Refactor Widget controls
3 participants