Code Quality: Introduced view models to widgets

src/Files.App/Actions/ActionExecutableType.cs

@@ -0,0 +1,26 @@
+// Copyright (c) 2023 Files Community
+// Licensed under the MIT License. See the LICENSE.
+
+namespace Files.App.Actions
+{
+	/// <summary>
+	/// Defines constants that specifies what context the action can be executed through.
+	/// </summary>
+	public enum ActionExecutableType
+	{
+		/// <summary>
+		/// The action is executable through <see cref="IDisplayPageContext"/>.
+		/// </summary>
+		DisplayPageContext,
+
+		/// <summary>
+		/// The action is executable through <see cref="IHomePageContext"/>.
+		/// </summary>
+		HomePageContext,
+
+		/// <summary>
+		/// The action is executable through <see cref="ISidebarContext"/>.
+		/// </summary>
+		SidebarContext
+	}
+}

src/Files.App/Actions/Content/RefreshItemsAction.cs

@@ -32,12 +32,14 @@ public RefreshItemsAction()
 			context.PropertyChanged += Context_PropertyChanged;
 		}
 
-		public async Task ExecuteAsync()
+		public Task ExecuteAsync()
 		{
 			if (context.ShellPage is null)
-				return;
+				return Task.CompletedTask;
 
-			await context.ShellPage.Refresh_Click();
+			context.ShellPage.ToolbarViewModel.InvokeRefreshRequested();
+
+			return Task.CompletedTask;
 		}
 
 		private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)

src/Files.App/Actions/Favorites/PinItemAction.cs

@@ -1,17 +1,15 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-using Files.App.Services;
-using Files.App.UserControls.Widgets;
-using Windows.Storage;
-
 namespace Files.App.Actions
 {
 	internal class PinItemAction : ObservableObject, IAction
 	{
-		private readonly IContentPageContext context;
+		private IContentPageContext ContentPageContext { get; } = Ioc.Default.GetRequiredService<IContentPageContext>();
+		private IQuickAccessService QuickAccessService { get; } = Ioc.Default.GetRequiredService<IQuickAccessService>();
+		private IHomePageContext HomePageContext { get; } = Ioc.Default.GetRequiredService<IHomePageContext>();
 
-		private readonly IQuickAccessService service;
+		private ActionExecutableType ExecutableType { get; set; }
 
 		public string Label
 			=> "PinToFavorites".GetLocalizedResource();
@@ -27,44 +25,59 @@ public bool IsExecutable
 
 		public PinItemAction()
 		{
-			context = Ioc.Default.GetRequiredService<IContentPageContext>();
-			service = Ioc.Default.GetRequiredService<IQuickAccessService>();
-
-			context.PropertyChanged += Context_PropertyChanged;
+			ContentPageContext.PropertyChanged += ContentPageContext_PropertyChanged;
 			App.QuickAccessManager.UpdateQuickAccessWidget += QuickAccessManager_DataChanged;
 		}
 
 		public async Task ExecuteAsync()
 		{
-			if (context.HasSelection)
-			{
-				var items = context.SelectedItems.Select(x => x.ItemPath).ToArray();
-
-				await service.PinToSidebarAsync(items);
-			}
-			else if (context.Folder is not null)
+			switch (ExecutableType)
 			{
-				await service.PinToSidebarAsync(context.Folder.ItemPath);
+				case ActionExecutableType.DisplayPageContext:
+					{
+						if (ContentPageContext.HasSelection)
+						{
+							var items = ContentPageContext.SelectedItems.Select(x => x.ItemPath).ToArray();
+							await QuickAccessService.PinToSidebarAsync(items);
+						}
+						else if (ContentPageContext.Folder is not null)
+						{
+							await QuickAccessService.PinToSidebarAsync(ContentPageContext.Folder.ItemPath);
+						}
+						break;
+					}
+				case ActionExecutableType.HomePageContext:
+					{
+						await QuickAccessService.PinToSidebarAsync(HomePageContext.RightClickedItem!.Path ?? string.Empty);
+						break;
+					}
 			}
 		}
 
 		private bool GetIsExecutable()
 		{
-			string[] favorites = App.QuickAccessManager.Model.FavoriteItems.ToArray();
+			var favorites = App.QuickAccessManager.Model.FavoriteItems;
 
-			return context.HasSelection
-				? context.SelectedItems.All(IsPinnable)
-				: context.Folder is not null && IsPinnable(context.Folder);
+			var executableInDisplayPage =
+				ContentPageContext.HasSelection
+					? ContentPageContext.SelectedItems.All(x => !favorites.Contains(x.ItemPath)) && ContentPageContext.SelectedItems.All(x => x.IsFolder)
+					: ContentPageContext.Folder is not null && !favorites.Contains(ContentPageContext.Folder.ItemPath);
 
-			bool IsPinnable(ListedItem item)
-			{
-				return
-					item.PrimaryItemAttribute is StorageItemTypes.Folder &&
-					!favorites.Contains(item.ItemPath);
-			}
+			if (executableInDisplayPage)
+				ExecutableType = ActionExecutableType.DisplayPageContext;
+
+			// TODO: Check if the item is folder
+			var executableInHomePage =
+				HomePageContext.IsAnyItemRightClicked &&
+				!favorites.Contains(HomePageContext.RightClickedItem!.Path ?? string.Empty);
+
+			if (executableInHomePage)
+				ExecutableType = ActionExecutableType.HomePageContext;
+
+			return executableInDisplayPage || executableInHomePage;
 		}
 
-		private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
+		private void ContentPageContext_PropertyChanged(object? sender, PropertyChangedEventArgs e)
 		{
 			switch (e.PropertyName)
 			{

src/Files.App/Actions/Favorites/UnpinItemAction.cs

@@ -1,16 +1,15 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-using Files.App.Services;
-using Files.App.UserControls.Widgets;
-
 namespace Files.App.Actions
 {
 	internal class UnpinItemAction : ObservableObject, IAction
 	{
-		private readonly IContentPageContext context;
+		private IContentPageContext ContentPageContext { get; } = Ioc.Default.GetRequiredService<IContentPageContext>();
+		private IQuickAccessService QuickAccessService { get; } = Ioc.Default.GetRequiredService<IQuickAccessService>();
+		private IHomePageContext HomePageContext { get; } = Ioc.Default.GetRequiredService<IHomePageContext>();
 
-		private readonly IQuickAccessService service;
+		private ActionExecutableType ExecutableType { get; set; }
 
 		public string Label
 			=> "UnpinFromFavorites".GetLocalizedResource();
@@ -26,41 +25,59 @@ public bool IsExecutable
 
 		public UnpinItemAction()
 		{
-			context = Ioc.Default.GetRequiredService<IContentPageContext>();
-			service = Ioc.Default.GetRequiredService<IQuickAccessService>();
-
-			context.PropertyChanged += Context_PropertyChanged;
+			ContentPageContext.PropertyChanged += ContentPageContext_PropertyChanged;
 			App.QuickAccessManager.UpdateQuickAccessWidget += QuickAccessManager_DataChanged;
 		}
 
 		public async Task ExecuteAsync()
 		{
-			if (context.HasSelection)
+			switch (ExecutableType)
 			{
-				var items = context.SelectedItems.Select(x => x.ItemPath).ToArray();
-				await service.UnpinFromSidebarAsync(items);
-			}
-			else if (context.Folder is not null)
-			{
-				await service.UnpinFromSidebarAsync(context.Folder.ItemPath);
+				case ActionExecutableType.DisplayPageContext:
+					{
+						if (ContentPageContext.HasSelection)
+						{
+							var items = ContentPageContext.SelectedItems.Select(x => x.ItemPath).ToArray();
+							await QuickAccessService.UnpinFromSidebarAsync(items);
+						}
+						else if (ContentPageContext.Folder is not null)
+						{
+							await QuickAccessService.UnpinFromSidebarAsync(ContentPageContext.Folder.ItemPath);
+						}
+						break;
+					}
+				case ActionExecutableType.HomePageContext:
+					{
+						await QuickAccessService.UnpinFromSidebarAsync(HomePageContext.RightClickedItem!.Path ?? string.Empty);
+						break;
+					}
 			}
 		}
 
 		private bool GetIsExecutable()
 		{
-			string[] favorites = App.QuickAccessManager.Model.FavoriteItems.ToArray();
+			var favorites = App.QuickAccessManager.Model.FavoriteItems;
 
-			return context.HasSelection
-				? context.SelectedItems.All(IsPinned)
-				: context.Folder is not null && IsPinned(context.Folder);
+			var executableInDisplayPage =
+				ContentPageContext.HasSelection
+					? ContentPageContext.SelectedItems.All(x => favorites.Contains(x.ItemPath)) && ContentPageContext.SelectedItems.All(x => x.IsFolder)
+					: ContentPageContext.Folder is not null && favorites.Contains(ContentPageContext.Folder.ItemPath);
 
-			bool IsPinned(ListedItem item)
-			{
-				return favorites.Contains(item.ItemPath);
-			}
+			if (executableInDisplayPage)
+				ExecutableType = ActionExecutableType.DisplayPageContext;
+
+			// TODO: Check if the item is folder
+			var executableInHomePage =
+				HomePageContext.IsAnyItemRightClicked &&
+				favorites.Contains(HomePageContext.RightClickedItem!.Path ?? string.Empty);
+
+			if (executableInHomePage)
+				ExecutableType = ActionExecutableType.HomePageContext;
+
+			return executableInDisplayPage || executableInHomePage;
 		}
 
-		private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
+		private void ContentPageContext_PropertyChanged(object? sender, PropertyChangedEventArgs e)
 		{
 			switch (e.PropertyName)
 			{

src/Files.App/Actions/FileSystem/ClearRecentItemAction.cs

@@ -0,0 +1,51 @@
+// Copyright (c) 2023 Files Community
+// Licensed under the MIT License. See the LICENSE.
+
+namespace Files.App.Actions
+{
+	internal class ClearRecentItemAction : ObservableObject, IAction
+	{
+		private IContentPageContext ContentPageContext { get; } = Ioc.Default.GetRequiredService<IContentPageContext>();
+		private IHomePageContext HomePageContext { get; } = Ioc.Default.GetRequiredService<IHomePageContext>();
+
+		public string Label
+			=> "RecentItemClearAll/Text".GetLocalizedResource();
+
+		public string Description
+			=> "RecentItemClearAll/Text".GetLocalizedResource();
+
+		public bool IsExecutable
+			=> GetIsExecutable();
+
+		public ClearRecentItemAction()
+		{
+			ContentPageContext.PropertyChanged += ContentPageContext_PropertyChanged;
+		}
+
+		public Task ExecuteAsync()
+		{
+			try
+			{
+				App.RecentItemsManager.ClearRecentItems();
+			}
+			catch (Exception) { }
+
+			return Task.CompletedTask;
+		}
+
+		private bool GetIsExecutable()
+		{
+			var executableInHomePage =
+				HomePageContext.IsAnyItemRightClicked &&
+				HomePageContext.RightClickedItem is WidgetRecentItem;
+
+			return executableInHomePage;
+		}
+
+		public void ContentPageContext_PropertyChanged(object? sender, PropertyChangedEventArgs e)
+		{
+			if (e.PropertyName is nameof(IContentPageContext.HasItem))
+				OnPropertyChanged(nameof(IsExecutable));
+		}
+	}
+}

src/Files.App/Actions/FileSystem/EjectDriveAction.cs

@@ -0,0 +1,52 @@
+// Copyright (c) 2023 Files Community
+// Licensed under the MIT License. See the LICENSE.
+
+namespace Files.App.Actions
+{
+	internal class EjectDriveAction : ObservableObject, IAction
+	{
+		private IContentPageContext ContentPageContext { get; } = Ioc.Default.GetRequiredService<IContentPageContext>();
+		private IHomePageContext HomePageContext { get; } = Ioc.Default.GetRequiredService<IHomePageContext>();
+		private DrivesViewModel DrivesViewModel { get; } = Ioc.Default.GetRequiredService<DrivesViewModel>();
+
+		public string Label
+			=> "EjectDrive".GetLocalizedResource();
+
+		public string Description
+			=> "EjectDrive".GetLocalizedResource();
+
+		public bool IsExecutable
+			=> GetIsExecutable();
+
+		public EjectDriveAction()
+		{
+			ContentPageContext.PropertyChanged += ContentPageContext_PropertyChanged;
+		}
+
+		public async Task ExecuteAsync()
+		{
+			var result = await DriveHelpers.EjectDeviceAsync(HomePageContext.RightClickedItem?.Path ?? string.Empty);
+
+			if (HomePageContext.RightClickedItem is WidgetDriveCardItem driveCardItem &&
+				driveCardItem.Item is DriveItem driveItem)
+				await UIHelpers.ShowDeviceEjectResultAsync(driveItem.Type, result);
+		}
+
+		private bool GetIsExecutable()
+		{
+			var executableInHomePage =
+				HomePageContext.IsAnyItemRightClicked &&
+				HomePageContext.RightClickedItem is WidgetDriveCardItem driveCardItem &&
+				driveCardItem.Item is DriveItem driveItem &&
+				driveItem.MenuOptions.ShowEjectDevice;
+
+			return executableInHomePage;
+		}
+
+		public void ContentPageContext_PropertyChanged(object? sender, PropertyChangedEventArgs e)
+		{
+			if (e.PropertyName is nameof(IContentPageContext.HasItem))
+				OnPropertyChanged(nameof(IsExecutable));
+		}
+	}
+}