Added initial SFTP implementation using SSH.NET #15477
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is around Storage Abstraction and it'll take a huge amount of time to get this abstraction ready for actual use. |
|
Sounds good |
yaira2
reviewed
May 26, 2024
0x5bfa
approved these changes
May 27, 2024
|
I've seen what's implemented for FTP support and tried to go for a similar implementation since it's pretty much the only non-shell-based storage implementation here with different protocols (AFAIK) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
Currently waiting for #8974 to be implemented (since the current way of hooking filesystems to the UI is a total mess I cannot figure out) along with #15473, this PR is to lay the groundwork for resolving #2407 and will be marked as ready when everything is finished.