Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for bulk renaming items #15537

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marianalcar
Copy link

Resolved / Related Issues

Previously, only one file could be renamed at the same time. We implemented the functionality of renaming multiple at the same time giving Files more flexibility and increased functionalities.

Steps used to test these changes

  1. Opened Files
  2. Went to each layout view
  3. Created different files and folders
  4. Selected them all and renamed them at the same time.

t the same time

We implemented the new functionality of renaming
multiple items at the same time, so that way it is
 easier to do so.
When the files have different extensions, the name
 stays the same, when it has the same extension,
the name has a number attached to the end as it is
 requested int the issue.
We did the behaviour to be similar to the Windows
File Explorer.

Co-authored-by: Rodrigo Leitao <[email protected]>
@yaira2 yaira2 changed the title Implement #8191: Support renaming multiple files at the same time Feature: Added support for bulk renaming items Jun 2, 2024
@0x5bfa
Copy link
Member

0x5bfa commented Jun 3, 2024

Could you provide a screen recording?

@yaira2
Copy link
Member

yaira2 commented Jun 3, 2024

Using the rename action when multiple items are selected should open a "Rename items" dialog

I compiled this branch, but it seems to be missing the dialog when bulk renaming.

@marianalcar
Copy link
Author

Could you provide a screen recording?

Files_MultipleFileRename_record.mp4

@yaira2
Copy link
Member

yaira2 commented Jun 4, 2024

@marianalcar the behavior seems to closely mimic File Explorer, while it technically works, we were hoping to add more advanced options in the future and therefore this feature requires a content dialog.

@marianalcar
Copy link
Author

@marianalcar the behavior seems to closely mimic File Explorer, while it technically works, we were hoping to add more advanced options in the future and therefore this feature requires a content dialog.

We thought that was the expected behaviour since you mentioned previously on a pr. We'll look into that and do a content dialog. Can you be more specific in what the dialog should have?

@yaira2
Copy link
Member

yaira2 commented Jun 9, 2024

Sorry about the confusion! For now, the rename dialog should consist of a simple title and text box for entering the new name. In the future, we may want to add more options.

@0x5bfa 0x5bfa added changes requested Changes are needed for this pull request and removed needs - code review labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes are needed for this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support renaming multiple files at the same time
5 participants