Code Quality: Conversion of strings with Toggle value to Show/Hide/Toggle using ICU syntax

src/Files.App/Actions/IAction.cs

@@ -10,6 +10,12 @@ public interface IAction
 		/// </summary>
 		string Label { get; }
 
+		/// <summary>
+		/// A label for display in context menus and toolbars where a different representation of the label is required.
+		/// </summary>
+		string LabelSpec
+			=> Label;
+
 		/// <summary>
 		/// A brief description of what the action does.
 		/// It will be used as the command name in the command palette.

src/Files.App/Actions/Show/ToggleInfoPaneAction.cs

@@ -8,7 +8,10 @@ internal sealed class ToggleInfoPaneAction : ObservableObject, IToggleAction
 		private readonly InfoPaneViewModel viewModel;
 
 		public string Label
-			=> "ToggleInfoPane".GetLocalizedResource();
+			=> "ToggleInfoPane".GetLocalizedFormatResource();
+
+		public string LabelSpec
+			=> "ToggleInfoPane".GetLocalizedFormatResource(!IsOn);
 
 		public string Description
 			=> "ToggleInfoPaneDescription".GetLocalizedResource();

src/Files.App/Data/Commands/ActionCommand.cs

@@ -27,7 +27,7 @@ public string Label
 
 		/// <inheritdoc/>
 		public string LabelWithHotKey
-			=> HotKeyText is null ? Label : $"{Label} ({HotKeyText})";
+			=> HotKeyText is null ? Action.LabelSpec : $"{Action.LabelSpec} ({HotKeyText})";
 
 		/// <inheritdoc/>
 		public string AutomationName
@@ -176,6 +176,7 @@ private void Action_PropertyChanging(object? sender, PropertyChangingEventArgs e
 					break;
 				case nameof(IToggleAction.IsOn) when IsToggle:
 					OnPropertyChanging(nameof(IsOn));
+					OnPropertyChanging(nameof(LabelWithHotKey));
 					break;
 				case nameof(IAction.IsExecutable):
 					OnPropertyChanging(nameof(IsExecutable));
@@ -194,6 +195,7 @@ private void Action_PropertyChanged(object? sender, PropertyChangedEventArgs e)
 					break;
 				case nameof(IToggleAction.IsOn) when IsToggle:
 					OnPropertyChanged(nameof(IsOn));
+					OnPropertyChanged(nameof(LabelWithHotKey));
 					break;
 				case nameof(IAction.IsExecutable):
 					OnPropertyChanged(nameof(IsExecutable));

src/Files.App/Extensions/MessageFormatExtensions.cs

@@ -115,7 +115,7 @@ public static string GetLocalizedFormatResource(this string resourceKey, params
 		/// <returns>The formatted localized resource string.</returns>
 		public static string GetLocalizedFormatResource(this string resourceKey, params object[] values)
 		{
-			var pairs = values.Select((value, index) => new KeyValuePair<string, object?>(index.ToString(), value))
+			var pairs = values.Select((value, index) => new KeyValuePair<string, object?>(index.ToString(), (value is bool b) ? (b ? 1 : 0) : value))
 							  .ToDictionary(pair => pair.Key, pair => pair.Value);
 			return GetLocalizedFormatResource(resourceKey, pairs);
 		}
@@ -126,6 +126,6 @@ public static string GetLocalizedFormatResource(this string resourceKey, params
 		/// </summary>
 		/// <param name="resourceKey">The key for the resource string.</param>
 		/// <returns>The localized resource string.</returns>
-		public static string GetLocalizedFormatResource(this string resourceKey) => GetLocalizedFormatResource(resourceKey, new Dictionary<string, object?>());
+		public static string GetLocalizedFormatResource(this string resourceKey) => GetLocalizedFormatResource(resourceKey, 0.ToFormatPairs(string.Empty));
 	}
 }

src/Files.App/Strings/en-US/Resources.resw

@@ -1053,7 +1053,7 @@
     <value>Toggle the details pane to view basic file properties</value>
   </data>
   <data name="ToggleInfoPane" xml:space="preserve">
-    <value>Toggle the info pane</value>
+    <value>{0, select, 1 {Show} 0 {Hide} other {Toggle}} the info pane</value>
   </data>
   <data name="ToggleInfoPaneDescription" xml:space="preserve">
     <value>Toggle the info pane to view the detail/preview panes</value>