-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Remove ini-parser-netstandard dependency #15654
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I sent a review for another PR. But as I said there, we should consider sections ([...]
) when parsing INI files.
How come? The same name in different sections seems not to be supported. We might want, but as of now we don't need to go such far. |
That should not be the case. In any case, I think we should define a section to avoid affecting other apps. |
Were these changes tested? I'm trying to test them on my side but it doesn't work. |
@hishitetsu I misunderstood what Wikipedia says and you're right. Now that the PR is ready again. |
f50648a
to
5b24ddf
Compare
if (SystemIO.File.Exists(iniPath) is false) | ||
return []; | ||
|
||
var lines = SystemIO.File.ReadLines(iniPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to consider the case where the file exists but cannot be accessed. See #15732
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.