Code Quality: Generative resource management and refactoring #15662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into xtorlukas/SGResw
XTorLukas
changed the title
|
Is this still on-development? |
yaira2
reviewed
Aug 26, 2024
| @@ -19,8 +19,10 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="MarcosLopezC.LightJson" Version="0.5.3" PrivateAssets="all" /> | |||
There was a problem hiding this comment.
We're trying hard to avoid additional references especially from third parties. Fyi @0x5bfa
There was a problem hiding this comment.
Source generator affects package size?
0x5bfa
reviewed
Aug 26, 2024
src/Files.Core.SourceGenerator/Generators/DependencyPropertyGenerator.cs
Outdated
Show resolved
Hide resolved
0x5bfa
approved these changes
Aug 27, 2024
src/Files.Core.SourceGenerator/Utilities/SourceGeneratorHelper.cs
Outdated
Show resolved
Hide resolved
|
Thank you |
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.