-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to pin folders to start #4059
Conversation
- Improved exception handling - Added check for fluent icons installed, and backup for Segoe MDL2 if they are not - Remove all symbols and spaces from ID - Use glyph helper and make glyph param optional - Moved asset generation to helper class
@winston-de Looks good! A couple of changes I would suggest
|
@yaichenbaum May I ask why not the glyphs? In my opinion it makes it much easier to quickly identify items, especially when they're in a folder or are small tiles. |
@winston-de The glyphs look a bit out of place on the fluent icon, we are also working on some custom icons that might look better here. |
@yaichenbaum Alright, I made the changes requested. I do hope something similar to the glyphs can be implemented in the future, as I think having some sort of icon is really useful :) |
Files/Filesystem/StorageEnumerators/UniversalStorageEnumerator.cs
Outdated
Show resolved
Hide resolved
@winston-de Some 🔥 ideas for icons: |
@d2dyno1 That should be made into its own issue as it looks like the icons are not happening this PR. |
Nice icons, except the one for documents. Isn't there an icon from editor or Wordpad we could use? |
@winston-de What assets are you using in the end? |
Closes #782
Tile assets are generated using the Win2D library from the
FolderIcon2Large.svg
asset and stored in the app cache.Icons for folders (if there is one) is obtained from
GlyphHelper.GetItemIcon
. Segoe Fluent Icons are used if they're present on the system, if not Segoe MDL2 Assets are used instead.Menu items for pinning:
Feedback is appreciated :)