Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to export\import settings #1260 #6001

Closed
wants to merge 1 commit into from

Conversation

oleitao
Copy link
Contributor

@oleitao oleitao commented Aug 31, 2021

Resolved / Related Issues

Details of Changes

  • Added import settings
  • Added export settings

@yaira2
Copy link
Member

yaira2 commented Aug 31, 2021

@oleitao we're currently on feature freeze as we work on getting v2 finished. Also, in the future, please let us know before you start work on a PR so we can collaborate on it 🙂

@files-community files-community locked and limited conversation to collaborators Aug 31, 2021
@gave92
Copy link
Member

gave92 commented Sep 4, 2021

Better wait for this after #6033 is implemented.

@gave92 gave92 closed this Sep 10, 2021
@files-community files-community unlocked this conversation Sep 13, 2021
@d2dyno1
Copy link
Member

d2dyno1 commented Sep 13, 2021

Better wait for this after #6033 is implemented.

@oleitao I'll also bundle this in #6113 since with the new implementation it'll be trivial to do so.

@yaira2
Copy link
Member

yaira2 commented Sep 13, 2021

Better wait for this after #6033 is implemented.

@oleitao I'll also bundle this in #6113 since with the new implementation it'll be trivial to do so.

With users being able to view the json file themselves, I'm not sure an additional button makes sense... It's up for discussion in the relevant issue.

@d2dyno1
Copy link
Member

d2dyno1 commented Sep 13, 2021

@oleitao I'll also bundle this in #6113 since with the new implementation it'll be trivial to do so.

With users being able to view the json file themselves, I'm not sure an additional button makes sense... It's up for discussion in the relevant issue.

I'd aim for two simple buttons for exporting and importing in the About page. Obviously users can do it manually by swapping the json file themselves but wouldn't it better if this action was wrapped around a nice UI? Also, some users wouldn't even know that such possibility exited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to export\import settings
4 participants