마이페이지 - 프로필 설정 페이지 퍼블리싱 #283
Open
+111
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Test Results314 tests 314 ✅ 26s ⏱️ Results for commit e2690e1. ♻️ This comment has been updated with latest results. |
wlrnjs
reviewed
Dec 30, 2025
src/app/(route)/mypage/_components/MyPageProfile/MyPageProfile.tsx
Outdated
Show resolved
Hide resolved
| <form onSubmit={handleSubmitMypageProfile} className="flex min-h-screen w-full flex-col"> | ||
| <div className="flex justify-center py-[30px]"> | ||
| <div className="relative h-[80px] w-[80px]"> | ||
| <Icon name="UserProfile" size={80} /> |
Member
There was a problem hiding this comment.
유저 프로필 이미지가 들어가는 부분이라 Icon 태그보단 Image 태그 사용해서
프로필 이미지가 없는 경우에는 user-profile.svg을 보여주는 방식이 더 좋을것 같습니다.
Contributor
Author
There was a problem hiding this comment.
정확한 분기 코드는 기능 구현 pr로 같이 올리고 지금은 임의 상수로 분기 처리만 해두었습니다!
src/app/(route)/mypage/profile/_components/MypageProfileForm/MypageProfileForm.tsx
Outdated
Show resolved
Hide resolved
src/app/(route)/mypage/profile/_components/MypageProfileForm/MypageProfileForm.tsx
Outdated
Show resolved
Hide resolved
src/app/(route)/mypage/profile/_components/MypageProfileForm/MypageProfileForm.tsx
Outdated
Show resolved
Hide resolved
src/app/(route)/mypage/profile/_components/MypageProfileForm/MypageProfileForm.tsx
Show resolved
Hide resolved
DevHyungJun
reviewed
Dec 30, 2025
Contributor
DevHyungJun
left a comment
DevHyungJun
left a comment
There was a problem hiding this comment.
지권님 코멘트 수정끝나시면, 머지하시면 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
관련 이슈
작업 내용
참고 사항
체크리스트