Implement proper collection name quoting/unquoting using Pure grammar utilities #4134
+28
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix MongoDB grammar parser to properly handle collection names with spaces and special characters by using standard Pure grammar utilities.
Changes
PureGrammarComposerUtility.convertIdentifier()
for automatic quotingPureGrammarParserUtility.fromGrammarString()
for proper unescaping of quoted collection namesWhat type of PR is this?
Bug Fix
What does this PR do / why is it needed ?
Previously, MongoDB collection names with spaces were not properly parsed - the quotes were not removed during parsing, causing collection names like
"Person With Spaces"
to be stored with the quotes included instead of justPerson With Spaces
.This fix ensures that:
Which issue(s) this PR fixes:
Fixes #4133
Other notes for reviewers:
The changes use existing Pure grammar utilities that are already used consistently across other modules in the Legend Engine codebase. All existing tests continue to pass, and a new test case validates the fix for collection names with spaces.
Does this PR introduce a user-facing change?
Yes - collection names with spaces and special characters will now be properly handled in MongoDB grammar files.
Test Results
All existing tests pass, including the new test case
testSingleCollectionMongoDBStoreGrammarWithSpaces()
which validates proper handling of collection names with spaces.Files Changed
MongoDBGrammarComposer.java
- Updated to usePureGrammarComposerUtility.convertIdentifier()
MongoDBGrammarParser.java
- Updated to usePureGrammarParserUtility.fromGrammarString()
TestMongoDBGrammarRoundTrip.java
- Added test case for collection names with spaces