Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TDS v2 (relation) groupBy in QueryBuilder #3892

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

travisstebbins
Copy link
Contributor

@travisstebbins travisstebbins commented Feb 12, 2025

Summary

Add support for using the new TDS v2 (relation) protocol with groupBy expressions. This includes

  • Supporting converting the QueryBuilder state to the new protocol when the user has groupBy functions (i.e., count, sum, etc.)
  • Supporting converting the new protocol with groupBy functions to QueryBuilder state

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Group by:
GroupByQuery

Group by with multiple columns:
MultiGroupByQuery

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: 063accf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 20.81575% with 563 lines in your changes missing coverage. Please review.

Project coverage is 46.34%. Comparing base (82ea08b) to head (063accf).

Files with missing lines Patch % Lines
...gation/QueryBuilderTypedAggregationStateBuilder.ts 24.58% 181 Missing ⚠️
...pure/v1/V1_QueryValueSpecificationBuilderHelper.ts 10.55% 178 Missing ⚠️
...QueryBuilderRelationAggregationValueSpecBuilder.ts 24.73% 143 Missing ⚠️
...ery-builder/src/stores/QueryBuilderStateBuilder.ts 25.00% 30 Missing ⚠️
...pureGraph/from/V1_ValueSpecificationTransformer.ts 0.00% 22 Missing ⚠️
...QueryBuilderProjectionValueSpecificationBuilder.ts 54.54% 5 Missing ⚠️
...tion/changeDetection/ValueSpecificationObserver.ts 0.00% 3 Missing ⚠️
...e/valueSpecification/RelationValueSpecification.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3892      +/-   ##
==========================================
- Coverage   46.36%   46.34%   -0.02%     
==========================================
  Files        2255     2257       +2     
  Lines      394495   395189     +694     
  Branches    11853    11024     -829     
==========================================
+ Hits       182901   183149     +248     
- Misses     210929   211602     +673     
+ Partials      665      438     -227     
Files with missing lines Coverage Δ
...l/pure/QueryBuilder_PureProtocolProcessorPlugin.ts 87.84% <100.00%> (ø)
...ry-builder/src/graph/QueryBuilderMetaModelConst.ts 100.00% <100.00%> (ø)
...ion/QueryBuilderRelationProjectValueSpecBuilder.ts 81.95% <ø> (ø)
...e/valueSpecification/RelationValueSpecification.ts 39.53% <0.00%> (-0.47%) ⬇️
...tion/changeDetection/ValueSpecificationObserver.ts 0.00% <0.00%> (ø)
...QueryBuilderProjectionValueSpecificationBuilder.ts 86.60% <54.54%> (-0.69%) ⬇️
...pureGraph/from/V1_ValueSpecificationTransformer.ts 24.01% <0.00%> (-0.91%) ⬇️
...ery-builder/src/stores/QueryBuilderStateBuilder.ts 79.67% <25.00%> (-1.89%) ⬇️
...QueryBuilderRelationAggregationValueSpecBuilder.ts 24.73% <24.73%> (ø)
...pure/v1/V1_QueryValueSpecificationBuilderHelper.ts 84.03% <10.55%> (-10.86%) ⬇️
... and 1 more

... and 260 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant