Open
Conversation
gxuu
force-pushed
the
mar-scaler-examples
branch
5 times, most recently
from
f6f17ab to
0b3299c
Compare
gxuu
commented
Mar 26, 2026
| "par_time = time.time() - start\n", | ||
| "\n", | ||
| "print(f\"Parallel runtime: {par_time / 60:.2f} minutes\")\n", | ||
| "print(f\"Speedup: {seq_time / par_time:.2f}x\")" |
Contributor
Author
There was a problem hiding this comment.
When running within the notebook, the speedup is consistently around 1.2x; while running locally on a 4 core machine gives a consistent speedup of 1.5x.
The aforementioned 4 core machine a.k.a my laptop has a past history of not able to correctly showcase the performance improvement with parfun.
gxuu
force-pushed
the
mar-scaler-examples
branch
2 times, most recently
from
b26f833 to
1d0c8f1
Compare
gxuu
force-pushed
the
mar-scaler-examples
branch
from
1d0c8f1 to
54291cf
Compare
gxuu
commented
Mar 27, 2026
| "[INFO]2026-03-27 07:35:09+0800: VanillaInformationController: exited\n", | ||
| "[INFO]2026-03-27 07:35:09+0800: ObjectStorageServer: stopped by user\n", | ||
| "Parallel: 11.96s\n", | ||
| "Speedup: 0.98x\n" |
Contributor
Author
There was a problem hiding this comment.
Bad speedup comes from mostly the fact that the sequential method completes fast. We should consider removing this example entirely. As a) it's not a real life scenario that we calculate with fixed beta and b) the easiest way of increasing execution time would be to increase number of iterations which makes no significant improvement from a Quant point of view.
gxuu
force-pushed
the
mar-scaler-examples
branch
from
54291cf to
9efd05f
Compare
Signed-off-by: gxu <georgexu420@163.com>
gxuu
force-pushed
the
mar-scaler-examples
branch
from
9efd05f to
13e44ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW.
Example code belongs to zimeng; I merely tuned the parameter a bit and removed the over-parallelism.