add test hex2byte and methods #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify method hex2byte
… into jrecalde-advance
danicricco
reviewed
Jun 9, 2023
| @@ -177,7 +181,19 @@ public static String trim (String s) { | |||
| public static String zeropad(String s, int len) throws ISOException { | |||
| return padleft(s, len, '0'); | |||
| } | |||
|
|
|||
|
|
|||
| public static boolean isHexadecimal(byte[] bytes) { | |||
There was a problem hiding this comment.
esta función entiendo que no se usa.
There was a problem hiding this comment.
no no la uso, se me paso quitarla, ahora lo quito.
danicricco
reviewed
Jun 9, 2023
|
|
||
| import org.junit.jupiter.api.Assertions; | ||
| import org.fest.assertions.Assert; |
There was a problem hiding this comment.
este import no es necesario y tampoco eliminar
There was a problem hiding this comment.
no modifiques las lineas que no necesitas. Es buena practicar modificar el mínimo posible.
danicricco
reviewed
Jun 9, 2023
| public void testHex2byte_InvalidInput_ThrowsExceptionWithMessage() { | ||
|
|
||
| Exception exception = assertThrows(IllegalArgumentException.class, () -> { | ||
| ISOUtil.hex2byte("1111"); |
There was a problem hiding this comment.
Este es un input válido, pero el objetivo es que pruebes con un input inválido.
There was a problem hiding this comment.
Si lo he probado de ambas formas Dani.
JuliaRecalde
force-pushed
the
jrecalde-advance1
branch
from
eaa4e6b
to
95a23dc
Compare
modify test ValidInput delete isHexadecimal modify test validinput modify test modify test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.