Customizable dictionary and list of supported applications for CEA #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to specify the list of actual Application IDs / Vendor IDs my equipment actually supports. In order to do so, I had to override the existing
Default
dict, which isn't possible everywhere, namely in the defaultStateMachine
creation (sm.New
usesdict.Default
).On top of that, declaring a new
*dict.Parser
is cumbersome since all I want is to use the default one but with less interfaces. So I made all the default XML dicts public, and added a helper to initialize a dictionary using those.With the changes in the PR, one can now change the default dict (and associated Application IDs / Vendor IDs) this way, reusing the dictionaries already declared in
go-diameter
:I did move all the XML (some 6k lines) to a new package because I believed it made more sense with the new structure, but I can revert that and make my changes in place if that's better.