Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WithinAppServiceConnection's ScheduledThreadPoolExecutor's con… #6414

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

gsakakihara
Copy link
Contributor

…figuration to avoid polling.

  • Changed WithinAppServiceConnection's ScheduledThreadPoolExecutor's configuration to allow the thread to stop polling after the timeout task has been canceled.

…figuration to avoid polling.

* Changed WithinAppServiceConnection's ScheduledThreadPoolExecutor's configuration to allow the thread to stop polling after the timeout task has been canceled.
Copy link
Contributor

github-actions bot commented Oct 24, 2024

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-messaging
### {{messaging_longer}} version 24.0.4 {: #messaging_v24-0-4}

* {{deprecated}} Deprecated additional FCM upstream messaging methods. See the
  [FAQ](https://firebase.google.com/support/faq#fcm-23-deprecation) for more
  details.

* {{changed}} Changed WithinAppServiceConnection's ScheduledThreadPoolExecutor's
  configuration to allow the thread to stop polling after the timeout task has
  been canceled.

#### {{messaging_longer}} Kotlin extensions version 24.0.4 {: #messaging-ktx_v24-0-4}

The Kotlin extensions library transitively includes the updated
`firebase-messaging` library. The Kotlin extensions library has no additional
updates.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Test Results

 64 files  ±0   64 suites  ±0   6m 16s ⏱️ +4s
487 tests ±0  487 ✅ ±0  0 💤 ±0  0 ❌ ±0 
980 runs  ±0  980 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c44c4c7. ± Comparison against base commit d402ad0.

♻️ This comment has been updated with latest results.

@gsakakihara gsakakihara merged commit 6383f6d into main Nov 4, 2024
33 checks passed
@gsakakihara gsakakihara deleted the gsakakihara/executor branch November 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants