Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tokenDelegate nullable in GACAppCheck #11592

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Make tokenDelegate nullable in GACAppCheck #11592

merged 2 commits into from
Jul 24, 2023

Conversation

andrewheard
Copy link
Contributor

Made the tokenDelegate parameter nullable in the constructor for GACAppCheck since the feature is not used by all integrators. E.g., it is not needed if token refresh isn't used --tokenDidUpdate:instanceName: would never get called.

  • Added parameter documentation to the initWithInstanceName:appCheckProvider:settings:tokenDelegate:resourceName:keychainAccessGroup constructor in GACAppCheck.
  • Renamed the umbrella header from AppCheck.h to AppCheckCore.h to match the framework name.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review July 24, 2023 15:28
@andrewheard andrewheard merged commit 632fcab into app-check-core Jul 24, 2023
33 checks passed
@andrewheard andrewheard deleted the ah/appcheck-tokendelegate branch July 24, 2023 16:09
@firebase firebase locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: appcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777