-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial config v2 support (partial) #13587
Draft
paulb777
wants to merge
6
commits into
main
Choose a base branch
from
pb-config-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 6d569dd FirebaseCoreClassesFIROptions[MODIFIED] -initWithContentsOfFile:Swift:
+ init ?( contentsOfFile configPath : String )
- init ?( contentsOfFile plistPath : String )
Objective-C:
+ - ( nullable instancetype ) initWithContentsOfFile :( nonnull NSString * ) configPath ;
- - ( nullable instancetype ) initWithContentsOfFile :( nonnull NSString * ) plistPath ; [ADDED] -initWithAppID:projectNumber:projectID:apiKey:Swift:
+ init ( appID : String , projectNumber : String , projectID : String , apiKey : String )
Objective-C:
+ - ( nonnull instancetype ) initWithAppID :( nonnull NSString * ) appID projectNumber :( nonnull NSString * ) projectNumber projectID :( nonnull NSString * ) projectID apiKey :( nonnull NSString * ) apiKey ; [ADDED] projectNumberSwift:
+ var projectNumber : String { get set }
Objective-C:
+ @property ( nonatomic , copy ) NSString * _Nonnull projectNumber ; |
FYI, addressed a merge conflict introduced by my #13627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial updates to support config v2.
To keep the changes smaller, keeping the FIROptions dictionary backing store, but that should probably go away.
The PR is still incomplete and only useful to see the direction it's headed.