Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial config v2 support (partial) #13587

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Initial config v2 support (partial) #13587

wants to merge 6 commits into from

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 5, 2024

Initial updates to support config v2.

To keep the changes smaller, keeping the FIROptions dictionary backing store, but that should probably go away.

The PR is still incomplete and only useful to see the direction it's headed.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Apple API Diff Report

Commit: 6d569dd
Last updated: Fri Sep 13 06:51 PDT 2024
View workflow logs & download artifacts


FirebaseCore

Classes

FIROptions
[MODIFIED] -initWithContentsOfFile:
Swift:
+  init ?( contentsOfFile configPath : String )
-  init ?( contentsOfFile plistPath : String )
Objective-C:
+  - ( nullable instancetype ) initWithContentsOfFile :( nonnull NSString * ) configPath ;
-  - ( nullable instancetype ) initWithContentsOfFile :( nonnull NSString * ) plistPath ;
[ADDED] -initWithAppID:projectNumber:projectID:apiKey:
Swift:
+  init ( appID : String , projectNumber : String , projectID : String , apiKey : String )
Objective-C:
+  - ( nonnull instancetype ) initWithAppID :( nonnull NSString * ) appID projectNumber :( nonnull NSString * ) projectNumber projectID :( nonnull NSString * ) projectID apiKey :( nonnull NSString * ) apiKey ;
[ADDED] projectNumber
Swift:
+  var projectNumber : String { get set }
Objective-C:
+  @property ( nonatomic , copy ) NSString * _Nonnull projectNumber ;

@ncooke3
Copy link
Member

ncooke3 commented Sep 13, 2024

FYI, addressed a merge conflict introduced by my #13627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants