Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rc-swift] Start RC Swift implementation #13931

Merged
merged 8 commits into from
Oct 23, 2024
Merged

[rc-swift] Start RC Swift implementation #13931

merged 8 commits into from
Oct 23, 2024

Conversation

paulb777
Copy link
Member

  • CocoaPods setup sufficient to run mixed language unit tests
  • RemoteConfigUpdate
  • UserDefaultsManager

Note: The first pass of the implementation is not worrying about access levels. Extra public's and @objc declarations so that the ObjC unit tests can continue to run.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Apple API Diff Report

Commit: fd2c8fb
Last updated: Sat Oct 19 07:11 PDT 2024
View workflow logs & download artifacts


FirebaseRemoteConfig

Classes

FIRRemoteConfig
[MODIFIED] -addOnConfigUpdateListener:
Swift:
+  func addOnConfigUpdateListener ( remoteConfigUpdateCompletion listener : @escaping ( FIRRemoteConfigUpdate ?, ( any Error )?) -> Void ) -> ConfigUpdateListenerRegistration
-  func addOnConfigUpdateListener ( remoteConfigUpdateCompletion listener : @escaping ( RemoteConfigUpdate ?, ( any Error )?) -> Void ) -> ConfigUpdateListenerRegistration
Objective-C:
+  - ( FIRConfigUpdateListenerRegistration * _Nonnull ) addOnConfigUpdateListener : ( FIRRemoteConfigUpdateCompletion _Nonnull ) listener ;
-  - ( FIRConfigUpdateListenerRegistration * _Nonnull ) addOnConfigUpdateListener : ( FIRRemoteConfigUpdateCompletion _Nonnull ) listener ;
[REMOVED] FIRRemoteConfigUpdate
[REMOVED] FIRRemoteConfigUpdate
Swift:
-    var updatedKeys : Set < String > { get }
Objective-C:
-    @property ( nonatomic , readonly , nonnull ) NSSet < NSString *> * updatedKeys ;

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CocoaPods setup sufficient to run mixed language unit tests

Nice approach!

.github/workflows/remoteconfig.yml Show resolved Hide resolved
@paulb777
Copy link
Member Author

Going to merge and can address any future comments in future rc-swift PRs

@paulb777 paulb777 merged commit 1d31fd9 into rc-swift Oct 23, 2024
34 of 35 checks passed
@paulb777 paulb777 deleted the pb-rc-swift-start branch October 23, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants