Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app_check, mobile): add option to pass debugTokens in initialization #13101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xVemu
Copy link

@xVemu xVemu commented Jul 26, 2024

Description

This feature allows a developer to use a pre-generated debug token instead of one that is generated at runtime. It's useful in CI environments, where you don't have an option to copy token from logs and paste it to Firebase Console.

Related Issues

Fix for: #11719

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone
Copy link
Contributor

Lyokone commented Jul 30, 2024

Hello @xVemu, thanks for your PR, could you add some tests in the tests/integration_test/firebase_app_check

@Lyokone Lyokone added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Jul 30, 2024
@xVemu
Copy link
Author

xVemu commented Aug 1, 2024

@Lyokone something like this?

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Aug 1, 2024
@Lyokone
Copy link
Contributor

Lyokone commented Aug 2, 2024

Thanks, I'll have a look at the API (we might want to have appleDebugToken instead of iosDebugToken). But otherwise it looks good :)

@Fudal
Copy link

Fudal commented Sep 23, 2024

@xVemu any update for that?

@xVemu
Copy link
Author

xVemu commented Sep 23, 2024

@xVemu any update for that?

I guess we have to wait for Firebase team?

@adonisRodxander
Copy link

@xVemu did you notice that some tests are failing?

@xVemu
Copy link
Author

xVemu commented Oct 9, 2024

@xVemu did you notice that some tests are failing?

Yep, I assume that's because I haven't changed pubspec for related packages.

@MoaidAlrazhy
Copy link

@xVemu have you got anytime to fix this ?

@xVemu
Copy link
Author

xVemu commented Nov 13, 2024

@xVemu have you got anytime to fix this ?

Fix what?

@MoaidAlrazhy
Copy link

MoaidAlrazhy commented Nov 13, 2024

@xVemu have you got anytime to fix this ?

Fix what?

the failing checks below that are blocking the PR.

@Fudal
Copy link

Fudal commented Dec 4, 2024

@xVemu are you able to tell who should doing something to merge it?

@russellwheatley russellwheatley changed the base branch from master to main December 11, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention This issue needs maintainer attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants