Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): TypeError when converting ActionCodeSettings to JS #13260

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

josh-burton
Copy link
Contributor

Description

When running on wasm web, a TypeError was being thrown as the dart string/boolean parameters of ActionCodeSettings were not being 'jsified' before passing through to the javascript sdk.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@josh-burton josh-burton mentioned this pull request Sep 3, 2024
10 tasks
@josh-burton josh-burton changed the title fix:(auth) TypeError when converting ActionCodeSettings to JS fix(auth): TypeError when converting ActionCodeSettings to JS Sep 3, 2024
@Lyokone
Copy link
Contributor

Lyokone commented Sep 3, 2024

@josh-burton
Copy link
Contributor Author

@Lyokone should be fixed now

@Lyokone Lyokone merged commit 6969e48 into firebase:main Sep 10, 2024
16 of 21 checks passed
@Lyokone
Copy link
Contributor

Lyokone commented Sep 10, 2024

Thanks @josh-burton for this one :)

@firebase firebase locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants