Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vertexai): fork vertexai sdk away from generative ai sdk. #13298

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

cynthiajoan
Copy link
Collaborator

@cynthiajoan cynthiajoan commented Sep 9, 2024

Description

Fork Vertex AI sdk from dependent from generative ai sdk.
This PR contains breaking changes and will be merged into the GA preparation branch.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@cynthiajoan cynthiajoan marked this pull request as ready for review September 10, 2024 17:50
@natebosch
Copy link
Contributor

natebosch commented Sep 10, 2024

There are tests we should bring over from the other repo.

I think the api client tests can likely be copied over directly. The chat tests too, though some might need to be deduplicated. Response parsing tests might need some fiddling, but with more of the parsing logic moving here we'll want to bring over the tests that match vertex.

@cynthiajoan cynthiajoan merged commit 611b56f into vertexai/prepare_ga Sep 10, 2024
15 of 22 checks passed
@cynthiajoan cynthiajoan deleted the vertexai/fork_off branch September 10, 2024 19:47
@firebase firebase locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants