Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, android): signInWithProvider() for non-default instances #13522

Conversation

rohitsangwan01
Copy link
Contributor

Description

This PR fixes the use of signInWithProvider for Firebase Auth instances that are not the default instance in Android

Previously, attempting to use signInWithProvider with a non-default instance would result in unexpected behaviour. This change ensures that the correct Firebase Auth instance is used when calling signInWithProvider, regardless of whether it is the default instance or not.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitsangwan01 - You just need to run melos run format-ci and this LGTM

@rohitsangwan01
Copy link
Contributor Author

@russellwheatley Done

@russellwheatley
Copy link
Member

russellwheatley commented Nov 19, 2024

@russellwheatley russellwheatley changed the title feat(auth): Support signInWithProvider for non-default instances feat(auth, android): Support signInWithProvider for non-default instances Nov 19, 2024
@russellwheatley russellwheatley changed the title feat(auth, android): Support signInWithProvider for non-default instances fix(auth, android): signInWithProvider() for non-default instances Nov 19, 2024
@russellwheatley russellwheatley merged commit f25e21c into firebase:main Nov 19, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants