Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth): fix typo in function documentation of createUserWithEmailAndPassword #16866

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JaFeKl
Copy link

@JaFeKl JaFeKl commented Dec 12, 2024

just a small typo I came across while checking the function documentation

Copy link

google-cla bot commented Dec 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@SelaseKay SelaseKay changed the title Small Typo in function documentation of createUserWithEmailAndPassword docs(auth): fix typo in function documentation of createUserWithEmailAndPassword Dec 12, 2024
@SelaseKay
Copy link
Contributor

Hi @JaFeKl, thanks for the fix. Kindly sign the CLA.

@JaFeKl
Copy link
Author

JaFeKl commented Dec 17, 2024

I sgined the CLA

@@ -221,7 +221,7 @@ class FirebaseAuth extends FirebasePluginPlatform {
/// has been expired
/// - **network-request-failed**:
/// - Thrown if there was a network request error, for example the user don't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - Thrown if there was a network request error, for example the user don't
/// - Thrown if there was a network request error, for example, if the user doesn't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaFeKl - also still saying CLA hasn't been signed 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants