ci(NoTicket): Use shared version bump action #156
Conversation
|
| run: | | ||
| # Bump version = <number> in version file | ||
| sed -i "s/SdkVersion string = .*/SdkVersion string = \"${{ steps.tag_generation.outputs.new_version }}\"/g" version/version.go | ||
| sed -i "s/SdkVersion string = .*/SdkVersion string = \"v${{ steps.version.outputs.new-tag }}\"/g" version/version.go |
There was a problem hiding this comment.
I see a lot of places where we do v${...}. Does this mean that the tag that we put in the release action does not have v at the beginning? For jdbc we set v3.6.2 in the job. In go when we what to release v3.6.2 do we trigger the job with 3.6.2?
There was a problem hiding this comment.
We don't provide the tag manually, it's automatically inferred from the commits made since the last tag in this action. It returns the new version without the v prefix. This is fine for Python SDK and some others as they keep releases numeric only. However, Go has v prefix in its releases so I'm adding it afterwards.
This workflow was using a hack that relied on an outdated action internal. It has since been refactored into a separate version bump action. This allows simplifying the workflow here while using a shared language-independent action.